unoplatform/uno

Add support for binding unwrapping through `BindingBase`

Open

#2,174 opened on Nov 24, 2019

View on GitHub
 (4 comments) (1 reaction) (1 assignee)C# (837 forks)batch import
difficulty/starter 🚀good first issuehelp wantedkind/enhancementno-reproproject/binding 🪢

Repository metrics

Stars
 (9,789 stars)
PR merge metrics
 (Avg merge 14d 8h) (130 merged PRs in 30d)

Description

What would you like to be added:

Adding a binding to a BindingBase property from the XAML should unwrap the binding expression.

For which Platform:

  • iOS
  • Android
  • WebAssembly
  • WebAssembly renderers for Xamarin.Forms
  • Windows
  • Build tasks
  • Solution Templates

Anything else we need to know?

This check should also validate for BindingBase: https://github.com/unoplatform/uno/blob/35835d4bc594d1f24dabed007740b4b2b47f473a/src/SourceGenerators/Uno.UI.SourceGenerators/XamlGenerator/XamlFileGenerator.cs#L2632

Contributor guide

Research direction
Inspect the XamlFileGenerator.cs file around line 2632 to understand how binding expressions are currently validated. Then add support for unwrapping when the property type is BindingBase.
Tech stack
csharp
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60