unoplatform/uno

Layout unit tests should be migrated to runtime tests

Open

#15,703 opened on Feb 29, 2024

View on GitHub
 (1 comment) (1 reaction) (1 assignee)C# (9,789 stars) (837 forks)batch import
area/tests 🧪difficulty/starter 🚀good first issuekind/bugproject/layout 🧱

Description

Current behavior

Using unit tests for layout-related stuff isn't a good idea for the following reasons:

  1. They are run against a "mock" layouting implementation, which can be very different from the actual implementation. So, results can be very deceiving.
  2. For some scenarios, we could be having different behavior on different platforms. We definitely want to catch those so that we are aware of them. Having the test to verify the actual behavior on all supported platforms is a lot better.

Expected behavior

Migrate to runtime tests

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

None

Environment

No response

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

Contributor guide

Tech stack
csharp
Domain
testingfrontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
C# programmingUnit testing experienceUno Platform basicsXAML layout concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Examine the existing layout unit tests in the repository (likely in the test directories). Identify the specific tests that need migration to runtime tests. Review any existing runtime test examples in the codebase to understand the migration pattern. Since this issue is assigned, coordinate with the assignee to avoid duplication. The scope and acceptance criteria should be clarified with maintainers in the issue comments.