unoplatform/uno

Switching branches clears recent/favorite samples in Samples app

Open

#14,306 opened on Nov 6, 2023

View on GitHub
 (5 comments) (1 reaction) (2 assignees)C# (9,789 stars) (837 forks)batch import
area/contributor-experiencedifficulty/starter 🚀good first issuekind/bug

Description

Current behavior

When a new sample is created and used in a branch, and then we switch back to master, samples app will attempt to parse the recent samples list and fail as the sample type does not exist in that assembly. The same goes for favorites.

Expected behavior

The missing samples should be gracefully ignored. Even if they are lost, it should not clear the whole list (e.g. the samples available on master should remain in the list)

How to reproduce it (as minimally and precisely as possible)

No response

Workaround

No response

Works on UWP/WinUI

No

Environment

Uno.UI / Uno.UI.WebAssembly / Uno.UI.Skia, Uno.WinUI / Uno.WinUI.WebAssembly / Uno.WinUI.Skia

NuGet package version(s)

No response

Affected platforms

No response

IDE

No response

IDE version

No response

Relevant plugins

No response

Anything else we need to know?

No response

Contributor guide

Tech stack
csharp
Domain
frontend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C# programmingUnderstanding of the Samples app structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Examine the Samples app code to understand how recent and favorite samples are persisted (likely in local storage or a file). Identify the deserialization logic that fails when a sample type is missing. The fix should gracefully handle missing sample types by skipping or showing a placeholder. Check the issue comments for any maintainer guidance on the preferred approach.