unoplatform/uno

Throw in case children are manipulated on non-UI thread

Open

#12,970 opened on Jul 21, 2023

View on GitHub
 (11 comments) (0 reactions) (0 assignees)C# (837 forks)batch import
difficulty/starter 🚀good first issuekind/enhancementlow-hanging-🍒no-repro

Repository metrics

Stars
 (9,789 stars)
PR merge metrics
 (Avg merge 14d 8h) (130 merged PRs in 30d)

Description

What would you like to be added:

Throwing an exception if anyone attempts to manipulate UIElement children on non-UI thread

Why is this needed:

Thread safety. Currently these attempts are normally executed, which may lead to race conditions (e.g. changing the visual tree while rendering is currently in progress)

For which Platform:

All

Contributor guide

Research direction
Locate the methods that manipulate UIElement's children (e.g., Children.Add) and add a thread check that throws an exception if called from a non UI thread.
Tech stack
csharp
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#XAML
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80