unoplatform/uno

`Given_ApplicationDataContainer_When_GetAllKeys` fails on iOS

Open

#1,285 opened on Jul 22, 2019

View on GitHub
 (4 comments) (0 reactions) (1 assignee)C# (837 forks)batch import
area/tests 🧪difficulty/medium 🤔has-repro-branchhelp wantedkind/bugplatform/ios 🍎project/core-tools 🛠️project/non-ui ⚙️

Repository metrics

Stars
 (9,789 stars)
PR merge metrics
 (Avg merge 14d 8h) (130 merged PRs in 30d)

Description

Current behavior

Given_ApplicationDataContainer_When_GetAllKeys fails on iOS when run on my device. The problem seems to be the fact, that even after clearing, the NSUserDefaults.StandardUserDefaults contains a ton of weird default settings like:

AppleLanguages, AppleLocale, NSInterfaceStyle, AppleITunesStoreItemKinds, AppleKeyboardsExpanded, PKKeychainVersionKey, ApplePasscodeKeyboards , AppleKeyboards, NSLanguages, NSInterfaceStyle

One of those being a date, which contains :, which Uno, unfortunately, uses as deserialization separator. This makes the DataTypeSerializer crash with exception.

Expected behavior

Runtime tests should run from SamplesApp without issues.

How to reproduce it (as minimally and precisely as possible)

Run Runtime tests via the SamplesApp on iOS.

Environment

Nuget Package:

Package Version(s):

Affected platform(s):

  • iOS
  • Android
  • WebAssembly
  • Windows
  • Build tasks

Visual Studio

  • 2017 (version: )
  • 2019 (version: 16.2 Preview 3)
  • for Mac (version: )

Relevant plugins

  • Resharper (version: )

Anything else we need to know?

Contributor guide

Research direction
Examine the DataTypeSerializer class to see how it uses a colon as a separator. Consider using a different separator or escaping colons in values from NSUserDefaults.
Tech stack
csharp
Domain
mobile
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#iOS development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75