unisonweb/unison

Tests that crash should get converted to failures

Open

#2,089 opened on Jun 7, 2021

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Haskell (304 forks)batch import
error-messagehelp wanted

Repository metrics

Stars
 (6,624 stars)
PR merge metrics
 (Avg merge 12d 19h) (6 merged PRs in 30d)

Description

Right now the test command isn’t expecting exceptions when evaluating the tests. When exceptions (like calls to bug) do occur, it isn’t correctly attributed to the failing test.

Contributor guide

Research direction
Examine the test runner code to understand how it evaluates tests and handles exceptions. Look for where exceptions like calls to 'bug' are thrown and ensure they are caught and attributed to the failing test.
Tech stack
haskell
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
HaskellGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35