unisonweb/unison

switch `Patch` to use `Map` instead of `Relation`

Open

#1,658 opened on Aug 17, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Haskell (304 forks)batch import
help wanted

Repository metrics

Stars
 (6,624 stars)
PR merge metrics
 (Avg merge 12d 19h) (6 merged PRs in 30d)

Description

We don't need the reverse index that Relation provides hanging out in memory.

We don't want to risk changing the existing V1 serialization format, so for simplicity, when constructing this PR, convert to/from a Relation using Relation.toMultimap/.fromMultimap before calling the serialization functions.

Contributor guide

Research direction
Investigate the current implementation of Patch and Relation, then replace Relation with Map internally, using Relation.toMultimap and Relation.fromMultimap for serialization compatibility.
Tech stack
None
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75