unisonweb/unison

in diffs, there are some stray newlines in the "Resolved name conflicts" section

Open

#1,480 opened on Apr 28, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Haskell (6,624 stars) (304 forks)batch import
Hacktoberfestcodebase-manager / ucmgood first issuehelp wanted

Description

Currently:

image

Proposed:

image

Same screenshot but separate issue from #1479.

Contributor guide

Tech stack
None
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of Unison's diff outputability to navigate the codebase
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the code responsible for rendering the 'Resolved name conflicts' section in diff output. Look for where newline characters are inserted, possibly in the formatting logic. The issue provides screenshots showing the current and proposed output. Check if there are any existing tests for this section. Make the change to remove the extra newlines.