unisonweb/unison

in diffs, `type not found` should include some hash

Open

#1,479 opened on Apr 28, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Haskell (6,624 stars) (304 forks)batch import
codebase-manager / ucmerror-messagehelp wanted

Description

Currently:

image

Proposed:

image

I'm wildly guessing that fixing this may involve futzing with DisplayThing.

Contributor guide

Tech stack
None
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of HaskellUnderstanding of unison's DisplayThing type
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the DisplayThing type and its implementation to find where error messages for 'type not found' are formatted. Look for how the type hash is omitted and add it to the display. The likely files are in the DisplayThing module or related UI code.