unisonweb/unison

`manageLinks` in `HandleInput` should have a stronger type

Open

#1,443 opened on Apr 20, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Haskell (6,624 stars) (304 forks)batch import
help wantedtech debt

Description

The current type of this function is:

    manageLinks :: [(Path', NameSegment.HQSegment)]
                -> [HQ.HashQualified]
                -> (forall r. Ord r
                    => (r, Reference, Reference)
                    ->  Branch.Star r NameSegment
                    ->  Branch.Star r NameSegment)
                -> Action m (Either Event Input) v ()

Since it takes names rather than references, it has to parse those names. This is probably OK for now, but may run into strange corner cases later.

Contributor guide

Tech stack
None
Domain
backenddeveloper experience
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
HaskellType level programming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Study the `manageLinks` function in the Unison codebase to understand its current usage and constraints. Propose a stronger type, possibly using existential types or type families, ensuring the change remains backward compatible. Discuss any potential side effects on other parts of the codebase.