unisonweb/unison

surprising name selection when working with numbered args

Open

#1,193 opened on Feb 4, 2020

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Haskell (304 forks)batch import
dxhelp wantedpapercut

Repository metrics

Stars
 (6,624 stars)
PR merge metrics
 (Avg merge 12d 19h) (6 merged PRs in 30d)

Description

In this screenshot, I diff two namespaces, base and merged. The result is that merged has four new definitions, relative to base. When I view one of them, I'm shown a name out of head, which wasn't on my radar (because we choose aliases somewhat arbitrarily).

image

It would be nice if it used the name corresponding to the number 1 I specified, namely merged.Either.swap.

image

Contributor guide

Research direction
Examine the diff viewer code to understand how names are selected when showing definitions. Focus on the logic that maps numbered arguments to names.
Tech stack
haskell
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitHaskell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60