umputun/remark42

Separate vendor from widgets bundles

Open

#901 opened on Feb 25, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (5,500 stars) (432 forks)user submission
enhancementfrontendgood-first-issuehelp wanted

Description

It's a really good thing in the case when remark42 installed on a page with the two widgets comments and last comments. Both of the widgets have bundles that include preact, redux, etc. It could be much more effective to separate vendor bundle and use the same piece of code for these widgets.

Contributor guide

Tech stack
javascripttypescriptgo
Domain
frontendperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with Go build systemunderstanding of JavaScript bundling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the current build process in the repository, likely involving Webpack or a similar bundler for the frontend widgets. Identify the common vendor dependencies (e.g., preact, redux) shared between 'comments' and 'last comments' widgets. Then propose splitting the vendor code into a separate bundle that can be cached and reused. Look for existing build configurations in the repository, such as webpack.config.js or Makefile, and study how bundles are currently generated. The implementation should ensure backward compatibility and maintain the existing widget APIs.