umputun/remark42

UI changes for GDPR

Open

#54 opened on May 26, 2018

View on GitHub
 (0 comments) (3 reactions) (0 assignees)Go (5,500 stars) (432 forks)user submission
discussionenhancementfrontendhelp wanted

Description

related to #47

I think we should add a popup/dialog after the user clicks on github/fb/goolge login links. This popup will ask for confirmation and will inform about cookies and will explain what info will be sent for such login.

Probably we should say:

 This service uses cookies.

 We use authentication cookies to identify the user once he has logged in. 
 
<show/hide detail>
|cookie name | description | duration| technical details|
|JWT | Signed web token identifying user| 1year| see https://tools.ietf.org/html/rfc7519|
|XSRF_TOKEN|Random ID preventing Cross-Site Request Forgery| 1year| see https://en.wikipedia.org/wiki/Cross-site_request_forgery|  

TBD: some text explaining what we send to oauth2 provider and what info we get back

if anyone has a good example what this dialog should be, pls share.

Contributor guide

Tech stack
javascripthtmlcss
Domain
frontendauthentication
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
basic understanding of cookiesfamiliarity with UI development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Review the existing login flow to determine where to insert the consent popup. Design a modal dialog that presents the cookie information as described in the issue, with a show/hide toggle for details. Implement the popup using JavaScript and HTML/CSS, ensuring it appears after clicking login links and before redirecting to OAuth provider. Optionally, add localization support.
UI changes for GDPR · umputun/remark42#54 | Good First Issue