umputun/remark42

Tweet embedding

Open

#355 opened on Jun 26, 2019

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Go (5,500 stars) (432 forks)user submission
enhancementfrontendhelp wanted

Description

Twitter supports embeding functionally by making smth like this

<blockquote class="twitter-tweet"><p lang="en" dir="ltr">
Dear tech bloggers,<br>Please stop using Foo, Bar, Baz, Fizz, Buzz, etc. when writing tutorials.
Use names of real things with context that make it easier to understand.</p>&mdash; Vx. 
CodePirate (@michelecynowicz) <a href="https://twitter.com/michelecynowicz/status/1142413927910912000?ref_src=twsrc%5Etfw">June 22, 2019</a></blockquote>
<script async src="https://platform.twitter.com/widgets.js" charset="utf-8"></script>

Obviously, such a thing will be stripped by remark42 as we don't allow any js in. Result looks like this:

for &mdash; I have opened #354

Can we make such embedded tweets looks a little bit better, maybe even formatted the way twitter shows it but without that widget? I'm not sure if we care but if UI guys can figure a nice way to do it will be glad to hear the idea.

Contributor guide

Tech stack
gohtmlcss
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingHTML/CSSremark42 internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Look at how remark42 currently renders comments and where tweet links are displayed. Review issue #354 for related work on HTML entities. Consider using oEmbed to fetch tweet data and render a static card without JavaScript. Check existing frontend code in the repository for patterns.