Reduce duplication of geometry dataclasses in `tfcoil/superconducting.py`
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 68/100
Research direction
Start in tfcoil/superconducting.py by comparing the geometry dataclasses with CICCAveragedTurnGeometry and tracing their uses. Refactor the relevant class to inherit from CICCAveragedTurnGeometry, then run the applicable PROCESS tests and confirm the geometry behavior remains unchanged without duplicated definitions.
Written by the indexing model from the issue text.
Description
Not a comment for you Jack, I think this class can inherit from CICCAveragedTurnGeometry which will reduce duplication. Will make an issue.
Originally posted by @timothy-nunn in https://github.com/ukaea/PROCESS/pull/4591#discussion_r3978246397
- Dominant language
- Python
- Stars
- 71
- Forks
- 27
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 33
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from ukaea/PROCESS
-
papercut
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Blocked Command Line Interface Input/Output Files
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Command Line Interface
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
Dependencies Physics Refactor
Difficulty 5/5 Over a week Newbie friendliness 25/100
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100