ucsd-progsys/liquidhaskell

Recover some tests of parsing errors

Open

#2,009 opened on Jun 16, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Haskell (1,306 stars) (157 forks)batch import
good first issue

Description

Some tests were disabled when implementing the expected errors flag. In general, these tests check the presence of certain parse errors.

  • BadAnnotation
  • BadAnnotation1
  • ErrLocation
  • ErrLocation2
  • ShadowMeasureVar

Reenable these and update the implementation of expected errors flags so it can be used with them.

Contributor guide

Tech stack
None
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the test files named BadAnnotation, BadAnnotation1, ErrLocation, ErrLocation2, and ShadowMeasureVar in the test suite. Understand how the expected errors flag works and update its implementation to work with these tests. Re enable the tests and ensure they pass.