ucsd-progsys/liquidhaskell

Termination error messages do not follow standard GHC format

Open

#1,961 opened on Apr 4, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Haskell (157 forks)batch import
good first issue

Repository metrics

Stars
 (1,306 stars)
PR merge metrics
 (Avg merge 2d 18h) (12 merged PRs in 30d)

Description

When checking tests/neg/AutoSize.hs, the folllowing is output:

**** LIQUID: UNSAFE ************************************************************

neg/AutoSize.hs:19:1: error:
    Termination Error
AutoSize.expSize
No decreasing parameter
   |
19 | expSize (EConst _) = 0
   | ^^^^^^^

Compare with:

**** LIQUID: UNSAFE ************************************************************

neg/Ast.hs:55:1: error:
    Liquid Type Mismatch
    .
    The inferred type
      VV : Ast.AstIndex
    .
    is not a subtype of the required type
      VV : {VV : Ast.AstIndex | Ast.isTypeIndex VV}
    .
    Constraint id 1
   |
55 | wrong = id1 astExpr
   |

and you can see the leading whitespace differences.

Contributor guide

Research direction
Compare the termination error message format with GHC's standard error format and adjust the leading whitespace and structure in the error printing code.
Tech stack
None
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75