ucsd-progsys/liquidhaskell

Plugin prints certain messages as non-json when `-ddump-json` is enabled

Open

#1,957 opened on Mar 30, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Haskell (1,306 stars) (157 forks)batch import
good first issue

Description

This complicates parsing the output of GHC, and breaks the contract that is implied by -ddump-json. See #1955 for an example of when this comes up.

Two things I've found are: the header (see also #1956 for another issue related to this), and certain WARNING:s that are printed when the plugin finds false in a specification. Unsure if this second one is just a debug message that was forgotten to be switched off or something.

Contributor guide

Tech stack
None
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of GHC's ddump json flagFamiliarity with Liquid Haskell plugin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the Liquid Haskell plugin code that prints messages when ddump json is enabled. Focus on the header output and any WARNING messages related to 'false' in specifications. Check the referenced issues #1955 and #1956 for context. Determine which parts of the code output non JSON and ensure they adhere to JSON format.
Plugin prints certain messages as non-json when `-ddump-json` is enabled · ucsd-progsys/liquidhaskell#1957 | Good First Issue