ucsd-progsys/liquidhaskell

Plugin always colors the `**** LIQUID: ` header, regardless of compiler settings

Open

#1,956 opened on Mar 30, 2022

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Haskell (157 forks)batch import
good first issue

Repository metrics

Stars
 (1,306 stars)
PR merge metrics
 (Avg merge 2d 18h) (12 merged PRs in 30d)

Description

This complicates tools which want to parse the output of the plugin and generate summary data (see #1955 for an example).

src/Language/Haskell/Liquid/UX/CmdLine.hs has a function reportResult that contains this enigmatic comment (see https://github.com/ucsd-progsys/liquidhaskell/blob/develop/src/Language/Haskell/Liquid/UX/CmdLine.hs#L744):

         -- For now, always print the \"header\" with colours, irrespective to the logger
         -- passed as input.

Contributor guide

Research direction
Examine the `reportResult` function in `src/Language/Haskell/Liquid/UX/CmdLine.hs` and modify the header printing to respect the logger's color settings instead of always using colors.
Tech stack
None
Domain
clideveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80