ucsd-progsys/liquidhaskell

Plugin always colors the `**** LIQUID: ` header, regardless of compiler settings

Open

#1,956 opened on Mar 30, 2022

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Haskell (1,306 stars) (157 forks)batch import
good first issue

Description

This complicates tools which want to parse the output of the plugin and generate summary data (see #1955 for an example).

src/Language/Haskell/Liquid/UX/CmdLine.hs has a function reportResult that contains this enigmatic comment (see https://github.com/ucsd-progsys/liquidhaskell/blob/develop/src/Language/Haskell/Liquid/UX/CmdLine.hs#L744):

         -- For now, always print the \"header\" with colours, irrespective to the logger
         -- passed as input.

Contributor guide

Tech stack
None
Domain
clideveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
HaskellLiquidHaskell
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the `reportResult` function in `src/Language/Haskell/Liquid/UX/CmdLine.hs` at line 744. The comment indicates that the header is forcibly printed with colors. The goal is to remove this override so that the output respects the compiler's color settings. Consider referencing issue #1955 for context on parsing output.
Plugin always colors the `**** LIQUID: ` header, regardless of compiler settings · ucsd-progsys/liquidhaskell#1956 | Good First Issue