uber/react-vis

Thoughts on viewBox property

Open

#901 opened on Aug 16, 2018

View on GitHub
 (8 comments) (1 reaction) (0 assignees)JavaScript (868 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (8,615 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I've been experimenting with react-vis components library and modifying it to pass a viewBox property all the way down to the svg element in XYPlot.

The results so far have been quite promising:

  • The elements inside the graph can easily be deployed in relation to each other using the internal coordinate system
  • Sizes can also be expresses in a way consistent with that system
  • The SVG scales appropriately, and it can be combined easily with flexbox.

So my question is: why is it that this doesn't have support out of the box? Is there any drawbacks I'm not noticing.

Thanks.

Contributor guide

Research direction
Investigate why viewBox is not natively supported in react vis XYPlot. Review the current SVG rendering implementation, analyze potential performance implications, and consider alternative ways to achieve responsive scaling. Also check if there are any existing workarounds or discussions in the community.
Tech stack
javascriptreact
Domain
frontend
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70