uber/react-vis

Discrete Color Legend strokeDashes and strokeWidth

Open

#860 opened on Jul 5, 2018

View on GitHub
 (6 comments) (0 reactions) (0 assignees)JavaScript (8,615 stars) (868 forks)batch import
help wanted

Description

The discrete color legend component should include props to style the stroke (dashed, width, etc.) so that it will match the line series in my graphs.

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The discrete color legend component is likely in `src/legends/DiscreteColorLegend.js`. Look at how other props like `stroke` are handled for line series components, and implement similar `strokeDashes` and `strokeWidth` props. Check existing tests and documentation for the legend to ensure consistency.