uber/react-vis

Discrete Color Legend strokeDashes and strokeWidth

Open

#860 opened on Jul 5, 2018

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)JavaScript (868 forks)batch import
help wanted

Repository metrics

Stars
 (8,615 stars)
PR merge metrics
 (PR metrics pending)

Description

The discrete color legend component should include props to style the stroke (dashed, width, etc.) so that it will match the line series in my graphs.

Contributor guide

Research direction
Look at the DiscreteColorLegend component in the source code. Identify how other legend components handle stroke styling (e.g., ContinuousColorLegend). Then implement strokeDashes and strokeWidth props in DiscreteColorLegend, ensuring they are passed to the underlying SVG elements. Update the component's propTypes and defaultProps. Test with a simple example.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75