uber/react-vis

Color assignment in DiscreteColorLegend does not match RadialChart

Open

#727 opened on Feb 21, 2018

View on GitHub
 (5 comments) (4 reactions) (0 assignees)JavaScript (8,615 stars) (868 forks)batch import
bughelp wanted

Description

I have a simple radial chart and a corresponding legend. Even though both the radial chart and the legend receive the series data in the same order, the color swatches do not match.

Here's a Codepen.

And a screenshot demonstrating the color difference:

Contributor guide

Tech stack
javascriptreact
Domain
frontenddata
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptReact fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the color assignment logic in DiscreteColorLegend and RadialChart components. Compare how colors are assigned based on series order. Look at the source code in `src/legends/DiscreteColorLegend.js` and `src/radial/RadialChart.js`. Check if there is a shared color scale or if each component assigns colors independently.