uber/react-vis

LineSeriesCanvas in FlexibleXYPlot container renders in incorrect size on retina screens

Open

#1,063 opened on Dec 12, 2018

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)JavaScript (868 forks)batch import
bughelp wanted

Repository metrics

Stars
 (8,615 stars)
PR merge metrics
 (PR metrics pending)

Description

Example: https://codepen.io/marton/pen/aPvody

This can be reproduced by putting any canvas series in a FlexibleXYPlot container as long as devicePixelRatio !== 1.

#605 seems related

Contributor guide

Research direction
Investigate how devicePixelRatio is handled in FlexibleXYPlot and LineSeriesCanvas components. Check if canvas dimensions are correctly scaled based on DPR.
Tech stack
javascriptreact
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ReactJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70