uber/queryparser

Column usage doesn't include hive struct accessors

Open

#11 opened on Aug 29, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Haskell (1,079 stars) (145 forks)batch import
good first issue

Description

For tables where the majority of 'columns' are abstracted under a top-level column, e.g. body or msg, we don't surface the struct accessor as the column name, rendering analysis of these queries unusable.

Ideally, if we had a msg.name, msg.attrs.foo, msg.attrs.bar struct, we'd see the leaf struct names as the column name, i.e. msg.name, msg.attrs.foo, etc. Instead, we currently see msg for all of them.

Contributor guide

Tech stack
sql
Domain
databaseanalytics
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of SQL parsingFamiliarity with Hive struct syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate the column name extraction logic in the parser. The issue requests that when accessing struct fields like msg.name, the column name should reflect the leaf struct name. Look at how the parser currently retrieves column names and identify where the struct accessor is lost. Consider modifications to propagate the full path. See the issue at https://github.com/uber/queryparser/issues/11.