uber/piranha

PiranhaJava - Doesn't add required space while removing parentheses

Open

#37 opened on May 14, 2020

View on GitHub
 (6 comments) (0 reactions) (0 assignees)Java (2,143 stars) (178 forks)batch import
good first issuelegacy-java

Description

Piranha changed return(true); to returntrue;. This is sort of related to #35 - in the sense that PiranhaJava doesn't validate the parens/spaces of the output generated.

This error probably would not have occured if the code had been Google Java formatted.

However, I thought I will bring it to your attention, since this is a case of Piranha introducing a "bug" instead of erring on the side of caution, like #35

Contributor guide

Tech stack
java
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Javastring manipulation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Investigate the code responsible for removing parentheses in flag conditions, particularly where the return statement's space is omitted. Look at the logic that generates the output string after transformation. Review issue #35 for related validation discussions. The fix likely involves ensuring a space is inserted between 'return' and the opening parenthesis when the parenthesis is removed.