Add inheritance of ABC from the abc package for abstract classes

Open
#650 1 comment 0 reactions 1 assignee View on GitHub

@Gagu422 is already working on this.

Since Dec 15, 2021.

Assessment

This issue has not been assessed yet.

Description

refactor

For the abstract classes like forecaster or base_estimator, we could inherit the ABC class from the abc package so that 1) we could prevent abstract classes from being instantiated; 2) we don't need to raise NotImplementedError manually each time

You could find further explanation in the stackoverflow here: https://stackoverflow.com/questions/56008847/when-should-one-inherit-from-abc

Dominant language
Python
Stars
2.1k
Forks
147
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from uber/orbit

All issues in uber/orbit

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.