uber/okbuck

[Lint] Lint should not depend on compilation

Open

#791 opened on Jan 8, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Java (1,533 stars) (180 forks)batch import
enhancementhelp wanted

Description

It runs on ASTs, so it can run in parallel to compilation.

As a potential followup, we can maybe look at making lint optionally run as an implicit concurrent action of building a src target

Contributor guide

Tech stack
java
Domain
build systemtooling
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Basic knowledge of Gradle pluginsUnderstanding of Buck build systemFamiliarity with linting concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Investigate how OkBuck currently runs lint tasks and their dependency on compilation. Look at the OkBuck Gradle plugin source (likely in src/main/groovy) to identify where lint is configured as a task. Consider how to decouple lint from compile tasks by running it on ASTs, possibly using custom task rules. The issue mentions a followup to make lint an implicit concurrent action; explore the Buck build system's ability to run actions in parallel.