typicode/jsonplaceholder

Nested resources are returning all resources

Open

#91 opened on Jan 10, 2019

View on GitHub
 (7 comments) (15 reactions) (0 assignees)HTML (4,964 stars) (567 forks)batch import
bughelp wanted

Description

When calling a GET for https://jsonplaceholder.typicode.com/posts/1/comments all comments for every post is returned. Expected behaviour is that only comments with postId of 1 should be returned. This is occurring in all of the nested resource examples.

Contributor guide

Tech stack
nodejsrest api
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic REST API understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The issue is that nested endpoints like /posts/:id/comments return all comments instead of filtering by postId. The fix likely involves modifying the route handler for nested resources to filter based on the parent resource id. Check the route definitions in the server code (likely in index.js or routes folder). Look for where comments are fetched and ensure the query parameter or URL parameter is used to filter. The expected behavior is that only comments with postId equal to the parent post id are returned.