typicode/json-server

POST failing when running json server via npm run

Open

#303 opened on Jun 9, 2016

View on GitHub
 (11 comments) (0 reactions) (0 assignees)JavaScript (75,566 stars) (7,285 forks)batch import
bughelp wanted

Description

I have json server configured to run conveniently using a npm-run-script like so npm run db.

{
  "name": "My App",
  "scripts": {
    "db": "json-server --watch db.json --port 3004"
  }
}

This works fine for all GET requests, however, fails for any POST request with the following stacktrace:

TypeError: _.maxBy is not a function
    at Function.createId (/Users/hady.osman/Development/react-native/PeopleNote/node_modules/json-server/src/server/mixins.js:44:16)
    at Function.module.exports.insert (/Users/hady.osman/Development/react-native/PeopleNote/node_modules/underscore-db/src/index.js:58:31)
    at baseWrapperValue (/Users/hady.osman/Development/react-native/PeopleNote/node_modules/lodash/index.js:2768:30)
    at LodashWrapper.wrapperValue (/Users/hady.osman/Development/react-native/PeopleNote/node_modules/lodash/index.js:6124:14)
    at LodashWrapper.<anonymous> (/Users/hady.osman/Development/react-native/PeopleNote/node_modules/lowdb/lib/_index.js:76:19)
    at LodashWrapper.wrapper [as value] (/Users/hady.osman/Development/react-native/PeopleNote/node_modules/lodash/index.js:3592:19)
    at create (/Users/hady.osman/Development/react-native/PeopleNote/node_modules/json-server/src/server/router/plural.js:214:8)
    at Layer.handle [as handle_request] (/Users/hady.osman/Development/react-native/PeopleNote/node_modules/express/lib/router/layer.js:95:5)
    at next (/Users/hady.osman/Development/react-native/PeopleNote/node_modules/express/lib/router/route.js:131:13)
    at next (/Users/hady.osman/Development/react-native/PeopleNote/node_modules/express/lib/router/route.js:125:14)

This is not a problem if I was to run the json-server command manually on the command line using the very same db.json that I have.

Seems like there is a problem with the scope that is used to run the script?

Contributor guide

Tech stack
javascriptnodejsexpress
Domain
backendapi
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js basicsjson server setupnpm scripts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the lodash version used in json server (likely v3.x) and check if .maxBy exists or if there's a compatibility issue when running via npm scripts. The error originates from node modules/json server/src/server/mixins.js:44 using .maxBy. Look at the dependency tree to see if there's a version mismatch causing lodash methods to be missing. Consider updating the dependency or using a different method.