typicode/hotel

Crashing - not sure of the cause

Open

#180 opened on Mar 7, 2017

View on GitHub
 (13 comments) (0 reactions) (0 assignees)JavaScript (9,939 stars) (474 forks)batch import
bughelp wanted

Description

I'm trying to use hotel for some NodeBB development. I've added the server via hotel add 'node app.js' --port 4567

A couple of seconds after starting hotel crashes.

I've pasted the full ~/.hotel/daemon.log

7 Mar 14:03:02 - Watching /Users/me/.hotel/servers
7 Mar 14:03:02 - /Users/me/.hotel/servers/nodebb.json added
7 Mar 14:03:02 - Add server nodebb
create /Users/me/.hotel/daemon.pid 66917
7 Mar 14:03:02 - Server listening on port 127.0.0.1:2000
7 Mar 14:03:02 - /Users/me/.hotel/servers/nodebb.json added
7 Mar 14:03:02 - Add server nodebb
7 Mar 14:03:23 - Resolve nodebb
7 Mar 14:03:23 - nodebb has started
7 Mar 14:03:31 - Resolve nodebb
7 Mar 14:03:31 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:31 - Resolve nodebb
7 Mar 14:03:31 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:31 - Resolve nodebb
7 Mar 14:03:31 - Resolve nodebb
7 Mar 14:03:31 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:31 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:32 - Resolve nodebb
7 Mar 14:03:32 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:32 - Resolve nodebb
7 Mar 14:03:32 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:32 - Resolve nodebb
7 Mar 14:03:32 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:32 - Resolve nodebb
7 Mar 14:03:32 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:32 - Resolve nodebb
(node:66917) Warning: Possible EventEmitter memory leak detected. 11 stop listeners added. Use emitter.setMaxListeners() to increase limit
7 Mar 14:03:32 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:32 - Resolve nodebb
7 Mar 14:03:32 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:32 - Resolve nodebb
7 Mar 14:03:32 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:32 - Resolve nodebb
7 Mar 14:03:32 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:32 - Resolve nodebb
7 Mar 14:03:32 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:32 - Resolve nodebb
7 Mar 14:03:32 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:33 - Resolve nodebb
7 Mar 14:03:33 - Resolve nodebb
7 Mar 14:03:33 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:33 - Proxy http://nodebb.dev to http://localhost:4567
7 Mar 14:03:33 - Resolve nodebb
7 Mar 14:03:33 - WebSocket - proxy WebSocket to ws://127.0.0.1:undefined
7 Mar 14:03:33 - Resolve nodebb
7 Mar 14:03:33 - Resolve nodebb
7 Mar 14:03:33 - Resolve nodebb
7 Mar 14:03:33 - Proxy error - connect ECONNREFUSED 127.0.0.1:80
Exiting
Stop daemon
Remove pid file
/Users/me/.nvm/versions/node/v6.9.1/lib/node_modules/hotel/lib/daemon/group.js:277
      var msg = errorMsg(err, req.hotel.item);
                                       ^

TypeError: Cannot read property 'item' of undefined
    at ProxyServer.handleProxyError (/Users/me/.nvm/versions/node/v6.9.1/lib/node_modules/hotel/lib/daemon/group.js:277:40)
    at ProxyServer.emit (/Users/me/.nvm/versions/node/v6.9.1/lib/node_modules/hotel/node_modules/eventemitter3/index.js:144:27)
    at ClientRequest.onOutgoingError (/Users/me/.nvm/versions/node/v6.9.1/lib/node_modules/hotel/node_modules/http-proxy/lib/http-proxy/passes/ws-incoming.js:151:16)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at Socket.socketErrorListener (_http_client.js:310:9)
    at emitOne (events.js:96:13)
    at Socket.emit (events.js:188:7)
    at emitErrorNT (net.js:1276:8)
    at _combinedTickCallback (internal/process/next_tick.js:74:11)

Contributor guide

Tech stack
nodejs
Domain
backendtooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Node.js basicsEventEmitter concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The crash occurs in group.js:277 when handling a WebSocket proxy error, where 'req.hotel.item' is undefined. Investigate the WebSocket proxy setup to see why 'req.hotel' is not populated. Look at the http proxy configuration for WebSocket passthrough and ensure the target port is correctly defined. The log shows 'WebSocket proxy WebSocket to ws://127.0.0.1:undefined', indicating the port is missing. Check how the server proxy target is constructed for WebSocket connections.