typelevel/spire

Use of bug in `cfor` macro

Open

#1,225 opened on Nov 25, 2022

View on GitHub
 (7 comments) (0 reactions) (0 assignees)Scala (238 forks)batch import
bughelp wanted

Repository metrics

Stars
 (1,775 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The cfor macro accidentally generated the desired code by using a bug in beta-reduction. This bug will be patched https://github.com/lampepfl/dotty/pull/16390 and cfor will need to be updated.

See https://github.com/dotty-staging/spire/compare/7f630c0209e327bdc782ade2210d8e4b916fddcc...99ea909d086e28e85dbdf8aa78ef0a83bf873405#diff-9cd0f3a9df06a2589472aa8dc960fd2a65a2b65f2f8c257addda1c86ebc31469

Contributor guide

Research direction
Understand the fix in the linked dotty PR (lampepfl/dotty#16390) and update the `cfor` macro to not rely on the buggy behavior.
Tech stack
scala
Domain
backendapi
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ScalaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40