typelevel/scalacheck

ConsoleReporter reports 0% frequencies due to rounding

Open

#576 opened on Oct 9, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Scala (395 forks)batch import
good first issuehelp wanted

Repository metrics

Stars
 (1,963 stars)
PR merge metrics
 (Avg merge 2d 1h) (5 merged PRs in 30d)

Description

Due to rounding the ConsoleReporter prints some frequencies as zero and this can report incorrect values when using classify. I had to inspect the FreqMap to check the counts as I was thinking my generator was not correct. It would be useful if the classifier reported the counts as well as the frequency.

Contributor guide

Research direction
Examine the rounding logic in Pretty.scala line 151 and the ConsoleReporter output to understand how frequencies become zero. Consider modifying the reporter to display raw counts alongside percentages.
Tech stack
scala
Domain
testing
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Scalaproperty based testing concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65