twitter/finagle

Support for touch, gat and gats commands in the memcached client

Open

#813 opened on Nov 7, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Scala (8,864 stars) (1,435 forks)batch import
help wanted

Description

Support for touch, gat and gats memcached commands

Expected behavior

The memcached client provides methods for touch, gat and gats memcached commands.

Actual behavior

The memcached client does not have support for the touch, gat and gats memcached commands.

This is a feature request and not a bug. Those commands are not documented in the wiki but are in the protocol description and are indeed supported by at least the latest version of memcached.

I would be happy to contribute a PR for this, but wanted to ask here first if this would be something that could be accepted of if there is some reason why you wouldn't want to add support for those commands.

Cheers :)

Contributor guide

Tech stack
scala
Domain
backendapi
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Finagle's memcached clientUnderstanding of ScalaFamiliarity with memcached protocol
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the existing memcached client implementation in Finagle to understand how get/set commands are implemented. Then use the memcached protocol documentation (linked in the issue) to implement touch, gat, and gats commands in a similar manner. Check for any test files for the existing client to maintain consistency.