twitter/finagle

Support for uploading files in HTTP client

Open

#501 opened on Apr 26, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Scala (1,435 forks)batch import
help wanted

Repository metrics

Stars
 (8,864 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I am abandoning scalaj-http in favour of Finagle. The only feature that I am missing is support for file uploads. From what I have found, there is no direct equivalent to this scalaj-http code:

val response = scalaj.http.Http(url)
  .postMulti(scalaj.http.MultiPart(
    "file",
    file.getName,
    Files.probeContentType(file.toPath),
    new FileInputStream(file),
    file.length(),
    onWrite))

Contributor guide

Research direction
Explore Finagle's HTTP client code to understand how requests are constructed and where multipart/form data encoding would be added. Look at existing tests for HTTP client to see patterns. Consider implementing a MultiPart class similar to scalaj http.
Tech stack
scala
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ScalaFinagle basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60