twitter/finagle

Support for uploading files in HTTP client

Open

#501 opened on Apr 26, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Scala (8,864 stars) (1,435 forks)batch import
help wanted

Description

I am abandoning scalaj-http in favour of Finagle. The only feature that I am missing is support for file uploads. From what I have found, there is no direct equivalent to this scalaj-http code:

val response = scalaj.http.Http(url)
  .postMulti(scalaj.http.MultiPart(
    "file",
    file.getName,
    Files.probeContentType(file.toPath),
    new FileInputStream(file),
    file.length(),
    onWrite))

Contributor guide

Tech stack
scala
Domain
apibackend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic understanding of HTTP multipart uploadsfamiliarity with Finagle's HTTP client
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue requests adding multipart file upload support to Finagle's HTTP client, similar to scalaj http's postMulti. To implement, explore the existing HTTP client code, likely in the com.twitter.finagle.http package, specifically request building classes (e.g., RequestBuilder). Look for how request bodies are constructed and how to add multipart/form data. The issue has 3 comments; review them for any additional context or suggestions. Consider examining how other HTTP clients handle file uploads and adapt that pattern to Finagle's API.