twitter/finagle

Set finagle-redis tests integration tests up to run as integration tests in SBT and Travis CI

Open

#360 opened on Apr 6, 2015

View on GitHub
 (1 comment) (0 reactions) (1 assignee)Scala (8,864 stars) (1,435 forks)batch import
good first issue

Description

We're currently excluding the finagle-redis integration tests in the SBT build. We should move them to the appropriate location, configure SBT to treat them as integration tests, and set up the Travis CI build to have a Redis server available to run them. (If this has a large impact on the Travis CI testing times we might need to turn them off there, but they currently run pretty quickly on my local machine.)

Contributor guide

Tech stack
scalaredis
Domain
testingci cdbuild system
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
SBT configurationScala basicsTravis CI setupRedis fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Examine the current SBT build file (build.sbt) to locate where finagle redis tests are excluded. Look at other modules in the finagle project that have integration tests as a reference for directory structure and SBT configuration. Then, modify the build.sbt to move the integration tests to src/it/scala and configure the SBT IntegrationTest plugin. Finally, add a .travis.yml configuration that installs a Redis server and runs the integration tests. Verify locally that the tests pass before submitting a pull request.