twbs/icons

Font hash is hardcoded for Sass

Open

#1,926 opened on Jan 12, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,049 forks)batch import
bugbuildhelp wanted

Repository metrics

Stars
 (6,955 stars)
PR merge metrics
 (Avg merge 1d 5h) (2 merged PRs in 30d)

Description

This broke in #1374 /CC @GeoSot @mdo.

We could probably get the hash by splitting the string but we'll need a custom Sass function since we still support node-sass (Hugo etc).

Alternatively, we could implement a hash template variable in our https://github.com/twbs/fantasticon fork.

Also, we still have some issues like #1381.

Contributor guide

Research direction
Investigate options to dynamically retrieve the font hash as described in the issue, focusing on creating a custom Sass function or modifying the fantasticon fork.
Tech stack
cssjavascript
Domain
frontendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
SassCSSGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50