twbs/icons

Font hash is hardcoded for Sass

Open

#1926 opened on Jan 12, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (6,955 stars) (1,049 forks)batch import
bugbuildhelp wanted

Description

This broke in #1374 /CC @GeoSot @mdo.

We could probably get the hash by splitting the string but we'll need a custom Sass function since we still support node-sass (Hugo etc).

Alternatively, we could implement a hash template variable in our https://github.com/twbs/fantasticon fork.

Also, we still have some issues like #1381.

Contributor guide

Tech stack
javascriptcss
Domain
frontendbuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Sass knowledgeNode.js basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the changes in #1374 that broke the font hash. Look at the fantasticon fork for implementing a hash template variable. Consider writing a custom Sass function as an alternative. Review issue #1381 for related context.