tursodatabase/turso-cli

Better error handling in csv table name

Open

#810 opened on Mar 8, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Go (50 forks)github user discovery
buggood first issue

Repository metrics

Stars
 (302 stars)
PR merge metrics
 (PR metrics pending)

Description

You can create a new db from CSV:

turso db create --from-csv test12_sanitized.csv --csv-table-name some_table
  1. If someone sends an invalid character for csv-table-name param, it just prints an error as something went wrong:
Error: could not load csv into new database file: exit status 1: 4572726f723a206e65617220222d223a2073796e746178206572726f720a

We should display the proper error

  1. We update our CLI to not to accept any special characters in csv-table-name param

reported here: https://discord.com/channels/933071162680958986/1215308443217563668/1215308443217563668

Contributor guide

Research direction
Examine the CLI's CSV table name handling in the create command; locate the error propagation path from the underlying database creation process; add input validation to reject special characters in csv table name and improve error messages to show the actual cause instead of hex error codes.
Tech stack
go
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60