tursodatabase/libsql

Total changes is accumulated per Hrana stream, not connection which is wrong

Open

#1,512 opened on Jun 27, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C (490 forks)batch import
buggood first issuehelp wantedremote protocol

Repository metrics

Stars
 (16,744 stars)
PR merge metrics
 (Avg merge 23h 19m) (1 merged PR in 30d)

Description

We currently implement total_changes() incorrectly for Hrana client-side protocol because we accumulate the changes per stream, but should do it per connection. I merged the incorrect solution as an intermediate step to expose the API to users because fixing this is a bit involved. Hrana does pass connection to stream but turns it into something useless because of the generics trickery there.

Contributor guide

Research direction
Inspect the Hrana stream implementation and trace how total changes is accumulated. Modify the code to accumulate per connection instead of per stream.
Tech stack
crust
Domain
databasebackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70