tursodatabase/libsql

Auto generate bindings when `libsql-sqlite3` is changed

Open

#1,039 opened on Feb 16, 2024

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C (490 forks)batch import
good first issue

Repository metrics

Stars
 (16,744 stars)
PR merge metrics
 (Avg merge 23h 19m) (1 merged PR in 30d)

Description

Whenever there is a change in libsql-sqlite3, we need to generate the sqlite header files and bindings. These commands to be run:

# this updates libsql-ffi and also libsql-sys
cargo xtask build-bundled 
# this updates bindings required for sqlite3-mc
cargo build --features multiple-ciphers

This is a manual step and easy to miss. It happened in #1027 which was fixed later by #1037

We should automate this, as part of the build process. We should also move multiple-ciphers build within build-bundled, so that there is only one command to run

Contributor guide

Research direction
Modify the `build bundled` xtask to include the `multiple ciphers` build and auto regenerate bindings when `libsql sqlite3` changes.
Tech stack
rustc
Domain
build system
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RustCargoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60