tsl0922/ttyd

Add specifying parameters in the configuration file

Open

#1,358 opened on May 6, 2024

View on GitHub
 (2 comments) (3 reactions) (0 assignees)C (814 forks)batch import
help wanted

Repository metrics

Stars
 (6,943 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

It would be really nice if there was an option to specify parameters for ttyd in the config file. In this case the program launch could be ttyd -conf config.cfg This would hide the display of login and password in the command line. Also, if the developer decides to add an option with the config file, you could implement picking up the config file if it has the same name as ttyd. For example, if there is a ttyd.cfg file in the working directory next to ttyd, then running ttyd without command line parameters would pick up the settings from ttyd.cfg.

Contributor guide

Research direction
Examine the existing command line argument parsing in main.c, design a simple config file format (e.g., key=value), and implement a parser that reads the config file before command line arguments so that CLI arguments can override config values. Ensure the config file path can be specified via a new conf option and also support auto detection of a ttyd.cfg file in the working directory.
Tech stack
c
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
CGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65