trycua/cua

Variable shadowing in computer class breaks shared directories.

Open

#124 opened on Apr 23, 2025

View on GitHub
 (3 comments) (0 reactions) (0 assignees)HTML (16,722 stars) (1,051 forks)batch import
good first issue

Description

This section in the Computer.__init__ method:

 if shared_directories:
    for path in shared_directories:
        abs_path = os.path.abspath(os.path.expanduser(path))  # type: ignore[attr-defined]
        if not os.path.exists(abs_path):  # type: ignore[attr-defined]
            raise ValueError(f"Shared directory does not exist: {path}")
        self.shared_paths.append(abs_path)

fails with:

abs_path = os.path.abspath(os.path.expanduser(path))  # type: ignore[attr-defined]
               ^^^^^^^
AttributeError: 'str' object has no attribute 'path'

because the module name is being shadowed by the init variable os, which is a string (macos, linux).

Please fix.

Contributor guide

Tech stack
python
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic Pythonunderstanding of variable shadowing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The bug is in the `Computer. init ` method where the variable `os` shadows the `os` module. The fix is to rename the variable `os` to something like `os name` to avoid shadowing. The specific code is in the file containing the `Computer` class (likely `computer.py` or similar). After renaming, ensure the `os.path` and `os.path.exists` calls work correctly.