trixi-framework/Trixi.jl

Make CI tests a bit less expensive

Open

#372 opened on Dec 8, 2020

View on GitHub
 (16 comments) (0 reactions) (0 assignees)Julia (686 stars) (153 forks)batch import
good first issuetesting

Description

For example, here is a list of examples that are relatively expensive on Windows (2D)

  • examples\2d\elixir_advection_amr.jl, 93.2s
  • examples\2d\elixir_advection_amr_nonperiodic.jl, 47.3s
  • examples\2d\elixir_hypdiff_nonperiodic.jl, 38.9s
  • examples\2d\elixir_euler_shockcapturing.jl, 46.5s
  • examples\2d\elixir_euler_blast_wave_amr.jl, 62.8s
  • examples\2d\elixir_euler_sedov_blast_wave.jl, 61.1s
  • examples\2d\elixir_euler_positivity.jl, 57.6s
  • examples\2d\elixir_mhd_alfven_wave.jl, 46.6s
  • examples\2d\elixir_mhd_alfven_wave_mortar.jl, 74.7s
  • examples\2d\elixir_mhd_orszag_tang.jl, 45.8s
  • examples\2d\elixir_lbm_lid_driven_cavity.jl, 40.6s
  • examples\2d\elixir_mhd_rotor.jl, 192s
  • examples\2d\elixir_mhd_blast_wave.jl, 158s

and Ubuntu (3D)

  • examples/3d/elixir_advection_mortar.jl, 40.7s
  • examples/3d/elixir_hypdiff_nonperiodic.jl, 51.9s
  • examples/3d/elixir_euler_amr.jl, 111s
  • examples/3d/elixir_euler_shockcapturing.jl, 67.1s
  • examples/3d/elixir_euler_sedov_blast_wave.jl, 72.0s (although it's using only 5 time steps)
  • examples/3d/elixir_eulergravity_eoc_test.jl, 44.2s (although it's using only 9 time steps)

Contributor guide

Tech stack
None
Domain
ci cdtestingperformance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic knowledge of Juliaunderstanding of CI workflowsfamiliarity with test optimization
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Review the list of expensive tests provided in the issue (e.g., examples/2d/elixir advection amr.jl). Identify common factors such as high time integration steps or large mesh resolutions. Propose modifications to reduce runtime while preserving test validity. Check the CI configuration files (e.g., .github/workflows/) to understand current test parameters. Consider reducing the number of time steps or using coarser meshes for these specific tests. Ensure changes are discussed with maintainers to maintain coverage.