trixi-framework/Trixi.jl

Disable storage of initital conditions in DiffEq solution type

Open

#368 opened on Dec 7, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Julia (686 stars) (153 forks)batch import
enhancementgood first issueperformance

Description

By default, the DiffEq package stores the initial conditions in the solution, which is a waste of memory and may become problematic for large simulations. This can be disabled by passing save_start=false to the call to solve(...) in the elixirs (see also the DiffEq docs).

We should consider adding save_start=false to the solve(...) call in all our example elixirs.

Contributor guide

Tech stack
None
Domain
performance
Issue type
performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
100
Research direction
Identify all example elixirs (likely .jl files in the examples directory) that contain solve(...) calls. Modify each call to include save start=false as a keyword argument. Verify that the examples still run correctly by executing them or checking for any errors. Refer to the DiffEq documentation linked in the issue for confirmation.
Disable storage of initital conditions in DiffEq solution type · trixi-framework/Trixi.jl#368 | Good First Issue