trixi-framework/Trixi.jl

Additional tests for fluxes: Invariance with respect to rotation and Consistency

Open

#1734 opened on Nov 12, 2023

View on GitHub
 (2 comments) (1 reaction) (0 assignees)Julia (686 stars) (153 forks)batch import
consistencygood first issuetesting

Description

We test a couple of fluxes for rotational invariance

https://github.com/trixi-framework/Trixi.jl/blob/1b75f5ecbd0b21d5cdce25f3e4f1884a06727fbb/test/test_unit.jl#L1174-L1195

and consistency: https://github.com/trixi-framework/Trixi.jl/blob/1b75f5ecbd0b21d5cdce25f3e4f1884a06727fbb/test/test_unit.jl#L614-L624 (for instance)

This could be expanded for other fluxes.

Contributor guide

Tech stack
None
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Julia basicsTesting in JuliaFlux function concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the existing test functions for rotational invariance and consistency linked in the issue. Add similar tests for other fluxes not yet covered. The linked code shows the pattern; follow it for remaining fluxes. Consider adding comments to explain the test purpose.