trixi-framework/Trixi.jl

New approximately EC compressible Euler flux

Open

#1,187 opened on Jul 25, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Julia (686 stars) (153 forks)batch import
enhancementgood first issue

Description

Comprehensive analysis of entropy conservation property of non-dissipative schemes for compressible flows: KEEP scheme redefined

CC @jlchan

Contributor guide

Tech stack
None
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
unclear
Prerequisites
compressible flow simulationentropy conservation theoryTrixi.jl package internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
First, read the linked paper (doi:10.1016/j.jcp.2022.111494) to understand the proposed approximately entropy conservative flux. Then, examine existing flux implementations in Trixi.jl, such as those in the 'src/equations' directory, to understand the code structure and interface. The new flux should be implemented as a function similar to existing ones, and tests should be added to verify entropy conservation properties. Consider opening a discussion to clarify the scope and requirements if needed.