trivago/parallel-webpack

`env` variable is not passed as first parameter to configuration function

Open

#88 opened on Oct 15, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (108 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (1,486 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Explain the problem

parallel-webpack is not passing an env parameter when configuration uses a function of the form:

module.exports = (env) => {
    console.log("env: ", env);  // Prints: env: {}
    return myConfig;  
}

Expected Behaviour

A valid env should be passed as first parameter to the configuration function.

Actual Behaviour

env is an empty dictionary.

Steps to reproduce

  1. Install parallel-webpack locally (using yarn, in my case)
  2. Create a simple module with a configuration function of the form given above
  3. Invoke as shown below:
$ ./node_modules/.bin/parallel-webpack --env.production=true

Provide your Environment details

  • Node version: v8.12.0
  • Operating System: Ubuntu 14.04.1 LTS
  • webpack version: 4.16.5
  • parallel-webpack version: 2.3.0

Contributor guide

Research direction
Examine how parallel webpack calls the configuration function and ensure the env argument is forwarded correctly from the CLI options.
Tech stack
javascriptnodejs
Domain
clibuild system
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gitwebpack
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75