trivago/melody

Nonbreaking space in template leads to hard-to-understand error message

Open

#85 opened on Jan 10, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (37 forks)auto 404
buggood first issue

Repository metrics

Stars
 (216 stars)
PR merge metrics
 (PR metrics pending)

Description

Explain the problem

When there is a nonbreaking space (unicode character code 160) in a template, the Melody parser will output an "Unknown token" error message. In the console, this usually looks like a normal space, this is why it's confusing.

Expected Behaviour

It might be good to test explicitly for the nonbreaking space, and inform the developer-user of it.

Actual Behaviour

"Unknown token" with the arrow pointing to what looks like a normal space. nbsp-error

Steps to reproduce

Insert a nonbreaking space in any template and try to compile it.

Provide a repository that reproduces issue if possible

Provide your Environment details

  • Node version:

  • Operating System:

  • melody version:

Contributor guide

Research direction
Locate the parser code that emits the 'Unknown token' error, then add a conditional check for the nonbreaking space character (Unicode U+00A0) to produce a clearer error message.
Tech stack
javascript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75