trinodb/trino

Migrate parser tests to use ParserAssert

Open

#7520 opened on Apr 7, 2021

View on GitHub
 (8 comments) (0 reactions) (2 assignees)Java (9,113 stars) (2,678 forks)batch import
good first issuetest

Description

Tests in https://github.com/trinodb/trino/blob/master/core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java that currently rely on assertExpression and assertStatement need to be updated to use ParserAssert.

Examples: https://github.com/trinodb/trino/blob/master/core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java#L234 https://github.com/trinodb/trino/blob/master/core/trino-parser/src/test/java/io/trino/sql/parser/TestSqlParser.java#L1247

Contributor guide

Tech stack
java
Domain
backendtesting
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaJUnit test experience
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the provided examples in TestSqlParser.java at lines 234 and 1247 to understand the current usage of assertExpression and assertStatement. Find the ParserAssert class in the same module to understand its API. Then systematically replace all occurrences of those assertion methods with equivalent ParserAssert calls, ensuring tests still pass.