Support setting column comment when creating table in JDBC based connector · trinodb/trino

(5 comments) (0 reactions) (0 assignees)Java (2,678 forks)batch import

enhancementgood first issue

Repository metrics

Stars: (9,113 stars)
PR merge metrics: (PR metrics pending)

Description

Currently, it's ignored silently. We need to consider some RDBMS doesn't support setting a column comment in CREATE TABLE (e.g. PostgreSQL).

https://github.com/prestosql/presto/blob/22717c61419c851b1c3814b60a3453b22d4a45ef/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java#L477

https://github.com/prestosql/presto/blob/22717c61419c851b1c3814b60a3453b22d4a45ef/presto-base-jdbc/src/main/java/io/prestosql/plugin/jdbc/BaseJdbcClient.java#L500-L510

Contributor guide

Research direction: Examine the current CREATE TABLE logic in BaseJdbcClient and implement column comment support via JDBC DatabaseMetaData or dialect specific SQL, using the column comment from the connector's metadata.
Tech stack: java
Domain: backendapidatabase
Issue type: Feature
Difficulty: 3
Estimated time: 1-2 days
Activity status: Active
Clarity: Clear
Prerequisites: JavaJDBC
Newbie friendliness: 60