trinodb/trino

"Self-suppression not permitted" possible when writing sequence file fails

Open

#3,326 opened on Apr 3, 2020

View on GitHub
 (4 comments) (0 reactions) (1 assignee)Java (2,678 forks)batch import
good first issue

Repository metrics

Stars
 (9,113 stars)
PR merge metrics
 (Avg merge 5d 18h) (254 merged PRs in 30d)

Description

[2020-04-02T12:48:06.159Z] ptl-presto-master   | java.lang.IllegalArgumentException: Self-suppression not permitted
[2020-04-02T12:48:06.159Z] ptl-presto-master   | 	at java.lang.Throwable.addSuppressed(Throwable.java:1072)
[2020-04-02T12:48:06.159Z] ptl-presto-master   | 	at io.prestosql.plugin.hive.util.SequenceFileRecordWriter.close(SequenceFileRecordWriter.java:72)
[2020-04-02T12:48:06.159Z] ptl-presto-master   | 	at io.prestosql.plugin.hive.RecordFileWriter.commit(RecordFileWriter.java:180)
[2020-04-02T12:48:06.159Z] ptl-presto-master   | 	at io.prestosql.plugin.hive.HiveWriter.commit(HiveWriter.java:86)
[2020-04-02T12:48:06.159Z] ptl-presto-master   | 	at io.prestosql.plugin.hive.HivePageSink.doFinish(HivePageSink.java:190)
[2020-04-02T12:48:06.159Z] ptl-presto-master   | 	at io.prestosql.plugin.hive.authentication.UserGroupInformationUtils.lambda$executeActionInDoAs$0(UserGroupInformationUtils.java:29)
...
[2020-04-02T12:48:06.159Z] ptl-presto-master   | 	at io.prestosql.$gen.Presto_0c13d16____20200402_124218_2.run(Unknown Source)

https://github.com/prestosql/presto/blob/f65f87f03f11bd3ff1c45320ab833b54c1ceea14/presto-hive/src/main/java/io/prestosql/plugin/hive/util/SequenceFileRecordWriter.java#L67-L72

Contributor guide

Research direction
Investigate the SequenceFileRecordWriter.close() method at lines 67-72 in presto hive/src/main/java/io/prestosql/plugin/hive/util/SequenceFileRecordWriter.java. The error occurs when an IOException during close is passed to addSuppressed() with the same exception instance, causing IllegalArgumentException. The fix should check if the exception is not the same instance before adding as suppressed. Also review RecordFileWriter.commit() for similar patterns.
Tech stack
java
Domain
backenddata
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Javaexception handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40